One thing that does seem to me to be fairly consistent is that presidents who restrict civil liberties, even in wartime, are usually judged harshly for it. So most people agree that one of the worst stains on the reputation of FDR, who is widely considered a great president, is the internment of Japanese Americans during World War II. Likewise, Lincoln is judged harshly for the suspension of habeas corpus.